619967 - non-directional filter primitive attributes with percentage values are not resolved correctly

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectMiniApproved/filters-displace-02-f.html currently fails due to some strange colors near the edge of the displaced image.

Comment 1

[Robert Longson [:longsonr]]

I can't see it. Can you describe in more detail. Maybe with a screenshot with the differences circled?

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Screenshot

This might be a Mac only issue -- I haven't tried others yet.

Comment 3

[Robert Longson [:longsonr]]

Attachment: patch?

Does this fix it? It seems the right thing to do according to http://www.w3.org/TR/SVG/coords.html#Units_viewport_percentage.

I don't know how to write a test for this.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's a bit weird that 'scale' is described as a number in some places but is treated in the primitiveUnits coordinate system, so it's really a length. The spec could use some cleanup there.

Comment 5

[Robert Longson [:longsonr]]

Cameron, do you think you'll get a chance to check this patch out soon?

Comment 6

[Cameron McCormack (:heycam)]

I will do so as soon as I return from my travels; ping me again if I don't respond before November 9.

Comment 7

[Robert Longson [:longsonr]]

It's November 10th now :-)

Comment 8

[Cameron McCormack (:heycam)]

Sorry for the delay.  I took a look at the patch, and I think we want this fix, but it doesn't fix the problem for this particular bug (the strange aqua colours at the left edge of the gradient in the top subtest).  I'll attach a test for the scale="" coordinate space conversion problem that this patch fixes.

BTW, does this also affect some lighting filter primitives?  It looks like they might also have been using this function.

Comment 9

[Cameron McCormack (:heycam)]

Attachment: test for attachment 559695 patch

Comment 10

[Cameron McCormack (:heycam)]

Comment on attachment 559695 [details] [diff] [review]
patch?

We want this patch, but it doesn't fix this bug.

Comment 11

[Robert Longson [:longsonr]]

Probably best to clone this bug and make the clone be about the original issue and then rename this one to what it fixes and land the patches. Can you do that Cameron please?

Comment 12

[Cameron McCormack (:heycam)]

Attachment: patch adding a test

test as a patch

Comment 13

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1848f311b786
https://hg.mozilla.org/integration/mozilla-inbound/rev/20ae82960dc3

Comment 14

[Robert Longson [:longsonr]]

Thanks Cameron and my apologies for muddying up this bug.

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/20ae82960dc3
https://hg.mozilla.org/mozilla-central/rev/1848f311b786